feat: slashing release #679

8sunyuan · 2024-08-12T22:39:06Z

Updated 9/20/24

Contract Descriptions

DONT REVIEW THE REWARDS COORDINATOR

AVSDirectory

The OperatorSets release has been combined into the Slashing release. This includes interfaces for AVS migration to operatorSets and register/deregister functionality.
Slashing and magnitude allocations revolve around the introduction of these operatorSets. More on this below...

New Core contract: AllocationManager! (basically the Slasher contract)

This is the Slasher contract, pending decision on rename or just changing back to Slasher.
This implements "unique security", stake is not reused across AVSs/operatorSets and operators allocate slashable proportions to each operatorSet. Imagine this as a pie chart where each slice gets given to a different operatorSet.
modifyAllocations can be called to configure updated allocations for a strategy per opSet. Allocations/deallocations are handled differently in the underlying storage.
slashOperator, from the perspective of an (operator, Strategy) tuple, slashes from current magnitude as well as queued deallocations. Whatever magnitude is slashed is also decremented from the totalMagnitude from the (operator, Strategy) tuple.
Deallocations are slashable while pending. Pending allocations on the other hand are not slashable (referring to the increased amount) because allocations are increases that are also decrementing from the non-allocated/non-slashable magnitude. We refer to this as freeMagnitude in storage.
Deallocations are all on a fixed 17.5 day delay
Allocation delays are configurable on a per operator basis. Updating the allocationDelay has a delay for it to take effect itself. Open PR for this is here. feat: allocation delay #740

StrategyManager/EigenPodManager/DelegationManager - Changes to Deposits/Withdrawals

This code comment explains a bunch:

   /*
 * There are 3 types of shares:
 *      1. ownedShares
 *          - These can be converted to an amount of tokens given a strategy
 *              - by calling `sharesToUnderlying` on the strategy address (they're already tokens 
 *              in the case of EigenPods)
 *          - These are comparable between operators and stakers.
 *          - These live in the storage of StrategyManager strategies: 
 *              - `totalShares` is the total amount of shares delegated to a strategy
 *      2. delegatedShares
 *          - These can be converted to shares given an operator and a strategy
 *              - by multiplying by the operator's totalMagnitude for the strategy
 *          - These values automatically update their conversion into tokens
 *              - when the operator's total magnitude for the strategy is decreased upon slashing
 *          - These live in the storage of the DelegationManager:
 *              - `delegatedShares` is the total amount of delegatedShares delegated to an operator for a strategy
 *              - `withdrawal.delegatedShares` is the amount of delegatedShares in a withdrawal          
 *      3. shares 
 *          - These can be converted into delegatedShares given a staker and a strategy
 *              - by multiplying by the staker's depositScalingFactor for the strategy
 *          - These values automatically update their conversion into tokens
 *             - when the staker's depositScalingFactor for the strategy is increased upon new deposits
 *             - or when the staker's operator's total magnitude for the strategy is decreased upon slashing
 *          - These represent the total amount of shares the staker would have of a strategy if they were never slashed
 *          - These live in the storage of the StrategyManager/EigenPodManager
 *              - `stakerStrategyShares` in the SM is the staker's principalShares that have not been queued for withdrawal in a strategy
 *              - `podOwnerShares` in the EPM is the staker's principalShares that have not been queued for withdrawal in the beaconChainETHStrategy
 */

Minimal changes to SM/EPM since the
Withdrawal struct in the DelegationManager has been changed from startBlock to startTimestamp. To account for legacy M2 withdrawals, we check that this field is less than a specific timestamp and handle accordingly.
DM: EIGEN strategy delay is currently set to 7 days so all the strategies currently have the same delay. We remove strategy specific delays entirely here but all withdrawals will be on a 17.5 day delay (same as deallocation delay)
DM: We've abstracted the EPM and SM behind a unified IShareManager interface
Accounting NOTEs:
- depositScalingFactor is the k value used in the accounting docs
- stakerStrategyShares is s
- operatorDelegatedShares is op
- totalMagnitude is m read from the AllocationManager

Misc Notes:

Using OZ CheckpointsUpgradeable library in the AllocationManager to keep track of historically timestamped magnitude values. This is required for staker withdrawal completion where the timestamped totalMagnitude value at completion may not be the current so we have a lookup for that. We renamed the Checkpoints library to Snapshots to avoid confusion with EigenPod checkpoints.
0.8.27 custom errors with requires (saves a lot of bytecode size)
thirdPartyTransfersForbidden is removed entirely. This mapping will be deprecated and never read from again.
We will likely deploy with optimizer-runs = 0-10 to save on contract size
DONT LOOK AT SCRIPTS OR TESTS YET

TODOs:

burning of slashed shares: requires scoping
BytecodeSize (if applicable)
EigenPodManager stuff: beaconchain slashing, negative shares
- proposal: eigenpods slashing updates #745

Deposits/Withdraws of Shares [WIP]

Confirm no overflow scenarios as part of scaling factor calculations in deposits/withdraws. Note that permissionless staking limits the number of shares in Strategies
Events

Allocator Configuration [WIP]

Figure out a tolerable rounding scheme for slashing magnitude allocations
Events

src/contracts/core/AVSDirectory.sol

src/contracts/core/DelegationManager.sol

src/contracts/core/AVSDirectory.sol

ypatil12

Review on alloc/dealloc

src/contracts/core/AVSDirectory.sol

MinisculeTarantula · 2024-08-22T20:37:27Z

require allocationDelay being set when calling modifyAllocations. Based on current implementation of a default allocation delay, if a shorter delay is set, it is possible to create a pending magnitudeUpdate that has a timestamp thats earlier than a already existing pending update. We need the checkpoints history to be asc sorted and figuring out some insertion method instead of pushing the history seems like too much overhead complexity.

Would it be bad / hard / undesirable to enforce this ordering on the checkpoints history level?

I would suggest that if an attempt is made to push an entry with a timestamp that is earlier than the timestamp of the previous entry, either (a) it's simply not allowed or (b) the new entry has its timestamp modified to match (or be 1 higher? not sure if the ascending ordering you have is strict or non-strict).

Perhaps some option (c) could work where you keep the original timestamp but overwrite the intentions of the other entry? IDK if that would be incompatible with other aspects of the storage model though.

I was initially thinking option (b) was the most logical but modifying entries before pushing them can be messy, especially if the entry or its contents is used elsewhere (e.g. if the timestamp is emitted in events, its hard to make sure the event emits the correct timestamp when you have conditional logic for modifying it).

ypatil12

Minor slashing comments

src/contracts/core/AVSDirectory.sol

ypatil12 · 2024-08-22T23:02:01Z

src/contracts/core/AVSDirectory.sol

+            {
+                uint256 queuedDeallocationIndicesLen =
+                    _queuedDeallocationIndices[operator][strategies[i]][msg.sender][operatorSetId].length;
+                for (uint256 j = queuedDeallocationIndicesLen; j > 0; --j) {


Since MAX_PENDING_UPDATES is 1, we don't need a loop here?

@gpsanant mentioned we want to check without assuming max 1 and be able to update in the future to change MAX_PENDING_UPDATES

@gpsanant Should I remove the loop?

src/contracts/core/AVSDirectory.sol

src/contracts/libraries/Checkpoints.sol

src/contracts/core/DelegationManagerStorage.sol

src/contracts/pods/EigenPodManager.sol

src/contracts/core/AVSDirectoryStorage.sol

src/contracts/core/DelegationManagerStorage.sol

src/contracts/core/AVSDirectory.sol

src/contracts/core/DelegationManager.sol

wadealexc

We need pausing on AllocationManager methods

Edit: fixed in #786

src/contracts/core/AllocationManager.sol

0xClandestine · 2024-09-29T00:36:03Z

We need pausing on AllocationManager methods

Added in #786

src/contracts/pods/EigenPodStorage.sol

wadealexc · 2024-10-01T19:23:15Z

src/contracts/interfaces/IAllocationManager.sol

+    struct MagnitudeInfo {
+        int128 pendingMagnitudeDiff;
+        uint64 currentMagnitude;
+        uint32 effectTimestamp;
+    }


Not a fan of ordering the fields like this -- IMO unless absolutely needed for storage packing, fields should be logically grouped by function. So, currentMagnitude should not sit between a pending diff and its effective timestamp.

src/contracts/core/AllocationManager.sol

wadealexc · 2024-10-07T14:40:48Z

src/contracts/core/AllocationManager.sol

+        // update the magnitude info in storage
+        _operatorMagnitudeInfo[operator][strategy][operatorSetKey] = mInfo;


You update this here, but also in 2/3 places where _completePendingModification is called

0xClandestine · 2024-10-07T17:11:00Z

src/contracts/core/AllocationManager.sol

+     * encoding of the operatorSet. This is to prevent duplicate operatorSets being passed in. The easiest way to ensure
+     * ordering is to sort allocated operatorSets by address first, and then sort for each avs by ascending operatorSetIds.
+     */
+    function modifyAllocations(


Should we include a signature based variant, so anyone can modify allocations on behalf of an operator?

removed because it was bloating code and we are adding delegated accounts

wdyt @ypatil12 @wadealexc ?

src/contracts/core/AllocationManager.sol

gpsanant · 2024-10-08T17:40:13Z

src/contracts/core/AllocationManager.sol

+
+            // If we've reached a pending modification that isn't completable yet,
+            // we can stop. Any subsequent modificaitons will also be uncompletable.
+            if (block.timestamp < info.effectTimestamp) {


check diff != 0

gpsanant · 2024-10-08T17:44:52Z

src/contracts/core/AllocationManager.sol

-    function _completePendingModification(
+    struct PendingMagnitudeInfo {
+        // Current magnitude allocated to this operatorSet
+        uint64 currentMagnitude;


abstract this as a nested MagnitudeInfo

wadealexc · 2024-10-10T16:24:16Z

src/contracts/core/DelegationManager.sol

    function registerAsOperator(
        OperatorDetails calldata registeringOperatorDetails,
+        uint32 allocationDelay,
        string calldata metadataURI
    ) external {


If we are comfortable changing this interface, let's make it a little more sane and use a new version of the OperatorDetails struct that includes an allocationDelay and does not have deprecated fields

src/contracts/core/AVSDirectoryStorage.sol

    /**
     * @notice Original EIP-712 Domain separator for this contract.
     * @dev The domain separator may change in the event of a fork that modifies the ChainID.
     * Use the getter function `domainSeparator` to get the current domain separator for this contract.
     */
-    bytes32 internal _DOMAIN_SEPARATOR;
+    bytes32 internal __deprecated_DOMAIN_SEPARATOR;


src/contracts/core/DelegationManager.sol

+    modifier onlyEigenPodManager() {
+        require(msg.sender == address(eigenPodManager), OnlyEigenPodManager());
+        _;
+    }


src/contracts/core/DelegationManagerStorage.sol

+
+    // Mutatables
+
+    bytes32 internal __deprecated_DOMAIN_SEPARATOR;


src/contracts/core/RewardsCoordinatorStorage.sol

-     * Use the getter function `domainSeparator` to get the current domain separator for this contract.
-     */
-    bytes32 internal _DOMAIN_SEPARATOR;
+    bytes32 internal __deprecated_DOMAIN_SEPARATOR;


src/contracts/core/StrategyManagerStorage.sol

+
+    // Mutatables
+
+    bytes32 internal __deprecated_DOMAIN_SEPARATOR;


wadealexc · 2024-10-10T19:27:09Z

src/contracts/libraries/SlashingLib.sol

+        StakerScalingFactors memory ssf
+    ) internal pure returns (uint64) {
+        return
+            !ssf.isBeaconChainScalingFactorSet && ssf.beaconChainScalingFactor == 0 ? WAD : ssf.beaconChainScalingFactor;


Can this be simplified to:

return ssf.isBeaconChainScalingFactorSet ? ssf.beaconChainScalingFactor : WAD;

Followup: the code seems to imply that it's possible for beaconChainScalingFactor to equal 0. However, this would cause mulDiv to revert if it's used as the denominator!

If this can be zero, we need to fix that.

If this can't be zero, this code is incorrect.

8sunyuan · 2024-10-15T15:12:33Z

src/contracts/core/AllocationManager.sol

+
+                    // For allocations, immediately add to encumberedMagnitude to ensure the operator
+                    // can't allocate more than their maximum
+                    info.encumberedMagnitude = _addInt128(info.encumberedMagnitude, info.pendingDiff);


Doesn't this need to be decremented as well in the case of deallocations?
Right now when we call _updateMagnitudeInfo we are passing in info which has the stale value of encumberedMagnitude.

I'm wrong, deallocations decrement from encumberedMagnitude when they are cleared which makes sense. The pending diff can change depending if the deallocation was slashed or not.

8sunyuan · 2024-10-16T15:37:16Z

src/contracts/core/AllocationManager.sol

+            // 2. If there is a pending deallocation, reduce pending deallocation proportionally.
+            // This ensures that when the deallocation is completed, less magnitude is freed.
+            if (info.pendingDiff < 0) {
+                uint64 slashedPending = uint64(uint256(uint128(-info.pendingDiff)).mulWad(params.wadToSlash));


slashedPending is not used anywhere else so can we remove this uint64 cast?

Added this rewards methods to ElContracts ChainWriter: - `set_claimer_for` - `process_claim` Still missing this methods (they are still not merged on dev branch of eigenlayer-contracts - will be merged with the [slashing PR](Layr-Labs/eigenlayer-contracts#679)): - `ForceDeregisterFromOperatorSets` - `SetOperatorCommissionBips`

chore: forge fmt src/contracts fix: ci and bindings chore: dmgr error tweaks chore: error tweaks for consistency and clarity feat: bump oz version (#755) * feat: bump oz version -> 0.4.9 - also moved remappings -> foundry.toml - removes remappings.txt * bindings --------- Co-authored-by: gpsanant <[email protected]> test: custom errors passing (#783) * test: custom errors AVSDir * test: custom errors IPausable * test: custom errors Delegation * test: custom errors EigenPodManager * test: custom errors EigenPod * test: custom errors Pausable * test: custom errors RewardsCoordinator * test: custom errors IStrategy * test: custom errors StrategyManager * test: custom errors DelegationManager * test: custom errors refactor: review reconciliation refactor: review reconciliation refactor: review reconciliation chore: forge fmt src/contracts feat: slashing * chore: pending delay calc cleanup * chore: storage pointer cleanup * eigenpods slashing updates (#745) * squash yet again * change again * update checkpoint struct * feat: AllocationManager Storage Simplification (#787) * feat: cleanup * feat: add helper func * fix: simplification * chore: clean up magnitude info usage and type conversions * refactor: review changes * fix: order struct params by size * fix: correct and simplify calc for slashed pending magnitude * fix: storage gap * feat: cleanup * chore: remove some type conversion bs and minor formatting * chore: clean up free magnitude logic * chore: rename pending deallocations and fix stack too deep * feat: slashing magnitudes cleanup (#786) * refactor: slashing magnitudes cleanup * refactor: assert `bipToSlash` is bounded * assert `bipsToSlash` is lte 100% and gt 0%. * refactor: move `isOperatorSlashable` -> AVSD * refactor: batch validate opsets on allocations - adds `AVSD.isOperatorSetBatch(operatorSets)` * feat: add pausing to ALM * refactor: remove single use helper - removes `_getLatestTotalMagnitude(operator, strategy)` * refactor: rename `ALLOCATION_DELAY_CONFIGURATION_DELAY` * refactor: remove `Slasher` * refactor: move constants + immutables to storage contracts * refactor: custom errors `RewardsCoordinatorStorage` * chore: dependency cleanup * fix: remove unused internal getter * chore: batch validate operator sets and minor cleanup * fix: fix stack too deep and compiler errors --------- Co-authored-by: wadealexc <[email protected]> feat: dm cleanup (#788) Co-authored-by: wadealexc <[email protected]> Revert "feat: dm cleanup (#788)" (#799) This reverts commit c27004e. fix: compiles (#800) fix: refactor (#801) * fix: refactor * default was history * reline * rename rename test: generally compiling + AVSM unit tests compiling chore: forge fmt src/contracts add events, fix bugs, abstract better (#806) * fix bugs, add events, cleanup * wrap conditional * fmt * only one slash per timestamp test(wip): generally compiling update docs (#804) fix: revert change to event feat: am refactor add to wads to slash cleanup refactor: change totalMagnitude to maxMagnitude * condense slashOperator params * some struct field renaming remove unused eigenpod storage chore: storage report (#809) * chore: storage report * patch eigenpod --------- Co-authored-by: gpsanant <[email protected]> feat: eip712 fixes (#808) * feat: use OZ SignatureChecker * feat: add `SignatureUtils` mixin * refactor: cleanup * feat: make storage report * storage report --------- Co-authored-by: gpsanant <[email protected]> test: slashing tests passing (#812) fix: merge issues update events refactor: rename total magnitudes to max magnitudes * various formatting and cleanup * standardize allocation manager getter functions * update and improve commenting refactor: reorder functions to match interface fix: remove memory overwrite bug in delegation manager chore: forge fmt refactor: clean up getDepositedShare logic chore: remove old oz + forge update foundry-rs/forge-std feat: replace getSlashableMagnitudes with general purpose allocation info query Feat: SM/StrategyBase Unit Tests + Formatting (#813) refactor: delegation manager refactors test: AllocationManager progress feat: change event names feat: update doc fix: compile test: AllocationManager progress fix: tests progress add Strategy <> OperatorSet mapping in storage, and APIs and events (#814) * feat: add strategy to operator set mapping with corresponding functions and events * fix: update * fix: remove pagination of getStrategiesInOperatorSet * fix: update * fix: compiles * fix: add checks * fix: address -> IStrategy * fix: storage gap --------- Co-authored-by: gpsanant <[email protected]> Slashing: DM Happy Path Test Cases (#815) * test: basic dm tests * test: start on share increase/decrease delegated shares tests * test: add DM unit tests passing except queue/complete * test: undelegate tests * test: queue withdrawals * test: completed DM happy path test cases * fix: compilation, rebase errors * chore: format Add view funcs (#816) * fix: add new view funcs * fix: update docs test: fix avsD tests (#817) chore: format fix: from scratch deploy feat: add shares to slashing event Slashing: Modify Allocations Happy Path Tests (#821) * refactor: add test contract per func * test: modify allocations * chore: format slashing: allocation delay happy path tests (#822) feat: wadSlashed (#820) Slashing: Clear Modification Queue Happy Path Tests (#823) test: basic allocation tests (#824) feat: inheritdoc refactor: alm test cleanup test: multiple allocations, only one slashed test: one pending alloc, slash test: revert bound refactor so tests pass Slashing: Add additional happy path AM test cases (#828) * test: happy path AM tests * chore: format Slashing: Get all tests passing (#829) * test: all tests passing * fix: mainnet integration test comment out Fix misset storage gaps (#831) * fix: misset storage gaps from #814 * fix: update gap to account for previous refactor fix: update coverage yml name (#833) Fix: Single Deallocation Queue (#827) * test: base regression * test: regression * fix: remove console * test: logs * test: add actual regression * fix: use a single deallocation queue * fix: comments * refactor: use deallocation queue everywhere * fix: address test comments * fix: test comment Feat: Update legacy withdrawal timestamp param to legacy withdrawal check (#836) * fix: make comment on timestamp clearer * chore: format Feat: Public Devnet Deploy (#838) * feat: slashing public devnet * fix: filepath * test: validation * fix: add test * fix: test fix: compile chore: format

github-advanced-security bot found potential problems Aug 12, 2024

View reviewed changes

src/contracts/core/AVSDirectory.sol Fixed Show fixed Hide fixed

8sunyuan mentioned this pull request Aug 12, 2024

feat: slashing magnitude poc #672

Closed

6 tasks

8sunyuan force-pushed the feat/operator-set-release branch from f2a7515 to f0873d1 Compare August 15, 2024 18:37

8sunyuan self-assigned this Aug 15, 2024

8sunyuan force-pushed the slashing-magnitudes branch from 9f91f03 to b9fe3e5 Compare August 15, 2024 23:42

github-advanced-security bot found potential problems Aug 16, 2024

View reviewed changes

src/contracts/core/DelegationManager.sol Fixed Show fixed Hide fixed

This comment was marked as spam.

Sign in to view

Layr-Labs deleted a comment from github-actions bot Aug 19, 2024

github-advanced-security bot found potential problems Aug 19, 2024

View reviewed changes

src/contracts/core/AVSDirectory.sol Fixed Show fixed Hide fixed

src/contracts/core/AVSDirectory.sol Fixed Show fixed Hide fixed

src/contracts/core/AVSDirectory.sol Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Aug 20, 2024

View reviewed changes

src/contracts/core/AVSDirectory.sol Fixed Show fixed Hide fixed

src/contracts/core/AVSDirectory.sol Fixed Show fixed Hide fixed

ypatil12 reviewed Aug 22, 2024

View reviewed changes

gpsanant reviewed Aug 23, 2024

View reviewed changes

src/contracts/core/AVSDirectory.sol Outdated Show resolved Hide resolved

wadealexc reviewed Aug 26, 2024

View reviewed changes

src/contracts/libraries/Checkpoints.sol Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Aug 27, 2024

View reviewed changes

src/contracts/core/DelegationManagerStorage.sol Fixed Show fixed Hide fixed

src/contracts/core/DelegationManagerStorage.sol Fixed Show fixed Hide fixed

src/contracts/pods/EigenPodManager.sol Fixed Show fixed Hide fixed

8sunyuan commented Aug 27, 2024

View reviewed changes

src/contracts/core/AVSDirectoryStorage.sol Outdated Show resolved Hide resolved

8sunyuan commented Aug 27, 2024

View reviewed changes

src/contracts/core/DelegationManagerStorage.sol Show resolved Hide resolved

gpsanant mentioned this pull request Aug 29, 2024

Feat: opSet -> operators enumerable Set #714

Merged

ypatil12 force-pushed the slashing-magnitudes branch from 678f212 to e70e85d Compare August 29, 2024 14:57

ypatil12 mentioned this pull request Aug 29, 2024

feat: operator sets #607

Closed

ypatil12 changed the base branch from feat/operator-set-release to dev August 29, 2024 20:24

github-advanced-security bot found potential problems Aug 30, 2024

View reviewed changes

src/contracts/core/AVSDirectory.sol Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Sep 4, 2024

View reviewed changes

src/contracts/core/AVSDirectory.sol Fixed Show fixed Hide fixed

gpsanant reviewed Sep 10, 2024

View reviewed changes

src/contracts/core/DelegationManager.sol Outdated Show resolved Hide resolved

gpsanant reviewed Sep 10, 2024

View reviewed changes

src/contracts/core/DelegationManager.sol Outdated Show resolved Hide resolved

gpsanant reviewed Sep 10, 2024

View reviewed changes

src/contracts/core/DelegationManager.sol Outdated Show resolved Hide resolved

gpsanant reviewed Sep 10, 2024

View reviewed changes

src/contracts/core/DelegationManager.sol Outdated Show resolved Hide resolved

gpsanant reviewed Sep 10, 2024

View reviewed changes

src/contracts/core/DelegationManager.sol Show resolved Hide resolved

wadealexc reviewed Sep 27, 2024

View reviewed changes

src/contracts/core/AllocationManager.sol Outdated Show resolved Hide resolved

wadealexc reviewed Sep 27, 2024

View reviewed changes

src/contracts/core/AllocationManager.sol Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Sep 30, 2024

View reviewed changes

src/contracts/pods/EigenPodStorage.sol Fixed Show fixed Hide fixed

wadealexc reviewed Oct 1, 2024

View reviewed changes

wadealexc force-pushed the slashing-magnitudes branch 2 times, most recently from f62d94e to 069c669 Compare October 4, 2024 15:06

wadealexc reviewed Oct 7, 2024

View reviewed changes

src/contracts/core/AllocationManager.sol Outdated Show resolved Hide resolved

wadealexc reviewed Oct 7, 2024

View reviewed changes

0xClandestine reviewed Oct 7, 2024

View reviewed changes

wadealexc reviewed Oct 8, 2024

View reviewed changes

src/contracts/core/AllocationManager.sol Outdated Show resolved Hide resolved

gpsanant reviewed Oct 8, 2024

View reviewed changes

wadealexc reviewed Oct 10, 2024

View reviewed changes

github-advanced-security bot found potential problems Oct 10, 2024

View reviewed changes

wadealexc reviewed Oct 10, 2024

View reviewed changes

8sunyuan commented Oct 15, 2024

View reviewed changes

TomasArrachea mentioned this pull request Oct 15, 2024

Add Rewards methods Layr-Labs/eigensdk-rs#145

Merged

8sunyuan commented Oct 16, 2024

View reviewed changes

ypatil12 force-pushed the custom-errors branch 2 times, most recently from db2ccda to 153d625 Compare October 17, 2024 06:45

ypatil12 force-pushed the slashing-magnitudes branch 5 times, most recently from eabea03 to 25617f0 Compare October 17, 2024 07:20

ypatil12 force-pushed the slashing-magnitudes branch from e94d7d9 to d98c5a7 Compare October 17, 2024 07:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: slashing release #679

feat: slashing release #679

8sunyuan commented Aug 12, 2024 •

edited by gpsanant

Loading

This comment was marked as spam.

ypatil12 left a comment

MinisculeTarantula commented Aug 22, 2024

ypatil12 left a comment

ypatil12 Aug 22, 2024

8sunyuan Aug 24, 2024

gpsanant Sep 20, 2024

0xClandestine Sep 22, 2024

wadealexc left a comment •

edited

Loading

0xClandestine commented Sep 29, 2024

wadealexc Oct 1, 2024

wadealexc Oct 7, 2024 •

edited

Loading

0xClandestine Oct 7, 2024

gpsanant Oct 8, 2024

gpsanant Oct 8, 2024

gpsanant Oct 8, 2024

wadealexc Oct 10, 2024

wadealexc Oct 10, 2024

wadealexc Oct 10, 2024

8sunyuan Oct 15, 2024

8sunyuan Oct 16, 2024

8sunyuan Oct 16, 2024

		// update the magnitude info in storage
		_operatorMagnitudeInfo[operator][strategy][operatorSetKey] = mInfo;


		// Mutatables

		bytes32 internal __deprecated_DOMAIN_SEPARATOR;

feat: slashing release #679

Are you sure you want to change the base?

feat: slashing release #679

Conversation

8sunyuan commented Aug 12, 2024 • edited by gpsanant Loading

Contract Descriptions

DONT REVIEW THE REWARDS COORDINATOR

AVSDirectory

New Core contract: AllocationManager! (basically the Slasher contract)

StrategyManager/EigenPodManager/DelegationManager - Changes to Deposits/Withdrawals

Misc Notes:

TODOs:

Deposits/Withdraws of Shares [WIP]

Allocator Configuration [WIP]

This comment was marked as spam.

ypatil12 left a comment

Choose a reason for hiding this comment

MinisculeTarantula commented Aug 22, 2024

ypatil12 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wadealexc left a comment • edited Loading

Choose a reason for hiding this comment

0xClandestine commented Sep 29, 2024

Choose a reason for hiding this comment

wadealexc Oct 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

8sunyuan commented Aug 12, 2024 •

edited by gpsanant

Loading

wadealexc left a comment •

edited

Loading

wadealexc Oct 7, 2024 •

edited

Loading